Skip to content
This repository was archived by the owner on May 21, 2021. It is now read-only.

Comments

remove method call at runtime#19

Open
ouertani wants to merge 3 commits intow11k:masterfrom
ouertani:master
Open

remove method call at runtime#19
ouertani wants to merge 3 commits intow11k:masterfrom
ouertani:master

Conversation

@ouertani
Copy link
Contributor

The purpose is the enhance performance by avoiding if test and remove method call at runtime.
Default distribution will leave all levels enabled at compile time and we can adjust this level to have specific level enabled at compile time.

Also I generated pom.xml from sbt tools to has some support for netbeans IDE.

Thanks in advance.

@hseeberger
Copy link

Thanks for your help!
I have got one question: Looking at your changes I cannot see that if-tests are avoided. Could you please clarify?

@ouertani
Copy link
Contributor Author

Yes If tests are avoided, and the who method too. As slf4j uses if test in internal, the duplication of if tests are due to pass by name param.

Here we hide all methods call at runtime.

@hseeberger
Copy link

OK, will pull in your changes except for pom.xml, because I don't want to maintain that one.

Please agree to distribute your work under a shared copyright and accept the license conditions of this project via email to [email protected].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants